Explicitly import CoreFoundation #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows TokamakDemo to be built with [latest SwiftWasm 5.4 toolchain](https://github.com/swiftwasm/swift/releases/tag/swift-wasm-5.4-SNAPSHOT-2021-06-17-a) in **debug mode** (compiler still crashes when building for release). BTW this import could be anywhere in the target, couldn't find a file that felt natural to include it in.
|
@kateinoigakukun do you think this is a good approach in the light of your recent changes to how CoreFoundation is linked in the upstream toolchain? |
|
To clarify, I remember Foundation folks saying that they plan to make CoreFoundation "private" and not available on non-Apple platforms, since its use there is very limited and may cause some issues in the future. Overall I'm leaning towards merging this as a temporary fix, but at first I would like to hear what Yuta thinks, if he's not too busy right now of course 🙂 |
|
Importing CoreFoundation is not exactly right approach, but it's ok to merge this as a temporary solution |
MaxDesiatov
reviewed
Jun 29, 2021
MaxDesiatov
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows TokamakDemo to be built with latest SwiftWasm 5.4 toolchain in debug mode (compiler still crashes when building for release).
BTW this import could be anywhere in the target, couldn't find a file that felt natural to include it in.